Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve #370 #371

Merged
merged 2 commits into from Aug 7, 2019
Merged

Solve #370 #371

merged 2 commits into from Aug 7, 2019

Conversation

damianooldoni
Copy link
Collaborator

Description

This PR solves a bug occurring while printing inherited objects of class gbif_data, e.g. the output of function occ_issues applied to objects of class gbif_data.
The bug is due to the fact that the output of occ_issues inherits class gbif_data but has no attribute type as occ_issues doesn't send any query to gbif API. By consequence, checking whether type is equal to many or single arise an error.

Related Issue

This PR should fix #370.

Example

See example in issue.

@sckott sckott added this to the v1.4 milestone Aug 7, 2019
Copy link
Contributor

@sckott sckott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@sckott sckott merged commit 246b57e into master Aug 7, 2019
@sckott sckott deleted the Solve-#370 branch October 29, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error in occ_issues egs with occ_data output
2 participants