Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gbifmap is broken #43

Closed
karthik opened this issue Sep 17, 2013 · 3 comments
Closed

gbifmap is broken #43

karthik opened this issue Sep 17, 2013 · 3 comments

Comments

@karthik
Copy link
Member

karthik commented Sep 17, 2013

All the examples and tutorials we have on the site and many of our talks don't work anymore. gbifmap was replaced by gbifmap_dens and gbifmap_list and this doesn't seem to map out correctly.

for e.g.

> a <- occurrencelist(scientificname = "Puma concolor", coordinatestatus = TRUE, maxresults = 40)
> gbifmap(a)
Error: could not find function "gbifmap"
@sckott
Copy link
Contributor

sckott commented Sep 17, 2013

Added gbifmap back with a message that it is deprecated, and to use gbifmap_list or gbifmap_dens. commit 0302fda

I agree these kinds of changes are to be avoided, in the branch based on the new api we move back to just having gbifmap. I will update the tutorial

@sckott sckott closed this as completed Sep 17, 2013
@karthik
Copy link
Member Author

karthik commented Sep 17, 2013

Just curious why you didn't overload the function. It makes more sense to me that we'd have one function called gbifmap with a option to be list or density.

gbifmap(foo, opts = "density")
gbifmap(foo, opts = "list")

seems cleaner.

@sckott
Copy link
Contributor

sckott commented Sep 17, 2013

That does make more sense. However, in the new api the density endpoint is gone, so you only have point occurrences to worry about, and we're moving back to just one mapping function gbifmap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants