Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions from ROpenSci Unconference (Spring 2016) #159

Merged
merged 220 commits into from Aug 23, 2016

Conversation

geanders
Copy link
Contributor

This pull requests incorporates work started at the spring's ROpenSci Unconference. Specific elements of this pull request are:

  • Vignette showing how to use rnoaa to pull weather data that can then be used in conjunction with air pollution data pulled using OpenAQ ("rnoaa_openaq.RMD").
  • Added text to help files for ghcnd_* family of functions to provide users more details and clarify differences between different functions in the family (all associated change are in the "ghcnd.R" file).
  • Added meteo_nearby_stations function, to identify stations near a latitude-longitude pair for Global Historical Climatology Network daily weather data (defined in "meteo_distance.R" file).
  • Added meteo_pull_monitors, to pull Global Historical Climatology Network daily weather data from multiple monitors with a single function call (defined in "helpers_ghcnd.R" file).
  • Added meteo_show_cache and meteo_clear_cache functions, for cache management (both files in "meteo_cache.r") (other functions we're adding do not rely on these functions).
  • Added meteo_coverage function to determine the coverage (percent of non-missing weather observations over dates pulled) for each weather monitor (in "meteo_utils.R" file), with its own method for plotting coverage.
  • Added vis_miss function to visualize missingness in a dataframe, including weather dataframes generated with rnoaa
  • Various helper functions to use with the above new functions.
  • Added basic tests for the two main functions added in this PR (in "test-meteo.R" file)

hrbrmstr and others added 30 commits April 1, 2016 09:49
Merge branch 'master' of github.com:hrbrmstr/rnoaa

# Conflicts:
#	man/clean_daily.Rd
…itors and bind results together as one dataframe
radius = 15,
year_min = 2016,
var = c("TAVG", "PRCP"))
stationsDelhi <- unique(rbind_all(stationsDelhi) %>% select(- distance))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geanders switch to use bind_rows instead, as rbind_all is deprecated, and change in import statement in rnoaa-package

@sckott
Copy link
Contributor

sckott commented Aug 17, 2016

@geanders thanks for the PR - made a few comments for changes

@geanders
Copy link
Contributor Author

Thanks so much for taking the time to review. I've made the suggested changes.

@sckott sckott merged commit 97aee14 into ropensci:master Aug 23, 2016
@sckott
Copy link
Contributor

sckott commented Aug 23, 2016

thanks @geanders merged

@geanders
Copy link
Contributor Author

Thank you so much! I really appreciate you taking the time on this pull request.

Would you let me know the next time you submit a version of rnoaa to CRAN? I have a student working on a package that builds on some of these functions, so it will be good to know for getting the dependencies straight in her package code.

Best,

Brooke


From: Scott Chamberlain notifications@github.com
Sent: Tuesday, August 23, 2016 1:11:11 PM
To: ropensci/rnoaa
Cc: Anderson,Brooke; Mention
Subject: Re: [ropensci/rnoaa] Additions from ROpenSci Unconference (Spring 2016) (#159)

thanks @geandershttps://github.com/geanders merged

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/159#issuecomment-241843978, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFVFiHV-MeqEczU_Bt8juzgC65I7Iwsmks5qi0XPgaJpZM4JkmdY.

@sckott sckott modified the milestone: v0.6 Aug 23, 2016
@sckott
Copy link
Contributor

sckott commented Aug 23, 2016

thanks for all your work on this, and the work of others, i'll add you as a contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet