Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T102 update cran comments #120

Merged
merged 1 commit into from Aug 23, 2020
Merged

Conversation

jooolia
Copy link
Member

@jooolia jooolia commented Aug 19, 2020

For issue #102 I have updated the cran-comments.md after running devtools::check_win_devel() on dev (will do again once in master just to be sure), but I saw that we needed to make a few little updates. Results from the win_devel check are here: https://win-builder.r-project.org/AOU3hKl01YHH/00check.log

Does this look ok? I tried to follow the advice I found here: http://r-pkgs.had.co.nz/release.html but happy to make any changes necessary.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2020

Codecov Report

Merging #120 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #120   +/-   ##
=======================================
  Coverage   64.46%   64.46%           
=======================================
  Files          13       13           
  Lines         318      318           
=======================================
  Hits          205      205           
  Misses        113      113           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d0722f...8a6032a. Read the comment docs.

Copy link
Contributor

@sinarueeger sinarueeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. So you did not get the note through R CMD check, but rather devtools::check_win_devel()?

@jooolia
Copy link
Member Author

jooolia commented Aug 23, 2020

This looks good to me. So you did not get the note through R CMD check, but rather devtools::check_win_devel()?

Yes the note did not show up for me when running things locally, only with the results from win-builder.

Thanks for having a look. :)

@jooolia jooolia merged commit 6984bb2 into dev Aug 23, 2020
@jooolia jooolia deleted the T102-update_cran_comments_take_two branch August 23, 2020 18:46
@sinarueeger
Copy link
Contributor

I have silly space issues on my laptop and can't run R CMD check, but will get access to another laptop in a week, so should be able to do these tests too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants