Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are the variant representations reported by rnsps the same as reported by NCBI? #94

Open
jooolia opened this issue May 12, 2020 · 2 comments

Comments

@jooolia
Copy link
Member

jooolia commented May 12, 2020

As brought up in #92 this should be checked. Does what we report in ncbi_snp_query_api() match what is reported in https://www.ncbi.nlm.nih.gov/snp/?

@sinarueeger
Copy link
Contributor

@jooolia is this still relevant?

@jooolia
Copy link
Member Author

jooolia commented Sep 29, 2020

Yes I think it should still be checked. I do not see where we have systematically checked this. However the additional unit tests that you added do reassure me, but I think this should still be checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants