You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! I don't know precisely all the internals of stats19 and details of STATS19 data but I simply wanted to point out a minor issue with get_stats19 and multiple years.
It seems that if the selected year is between 2005 and 2014, then the R function downloads all car crashes data from 2005 to 2014:
The problem is that if I ask for all car crashes between 2005 and 2010 (i.e. get_stats19(2005:2010)), then the same data are being read for 6 times. Obviously this is not a real problem and the solution is extremely easy (just ask for 2005), but maybe it's worth creating a warning message in these cases and change the input years to only 2005. What do you think?
The text was updated successfully, but these errors were encountered:
That is an issue. It's because there is a single file for all those years. Could a solution be to pre-check the years and if there are multiple years within that range remove all but one of them (the most recent)?
If you're willing and able that would be amazing. Thanks for reporting and (if you find time and motivation) potentially fixing this pesky edge case issue!
Hi! I don't know precisely all the internals of
stats19
and details of STATS19 data but I simply wanted to point out a minor issue withget_stats19
and multiple years.It seems that if the selected year is between 2005 and 2014, then the R function downloads all car crashes data from 2005 to 2014:
The problem is that if I ask for all car crashes between 2005 and 2010 (i.e.
get_stats19(2005:2010)
), then the same data are being read for 6 times. Obviously this is not a real problem and the solution is extremely easy (just ask for 2005), but maybe it's worth creating a warning message in these cases and change the input years to only 2005. What do you think?The text was updated successfully, but these errors were encountered: