Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target class #4

Closed
wlandau opened this issue Mar 29, 2020 · 6 comments
Closed

target class #4

wlandau opened this issue Mar 29, 2020 · 6 comments

Comments

@wlandau
Copy link
Collaborator

wlandau commented Mar 29, 2020

  • cmd field.
  • All dependency hashes:
    • cmd$hash().
    • Hashes of the dependencies of cmd from hash_envir().
    • Hashes of the targets directly upstream.
  • Names of the targets directly upstream.
  • Delegate pkgs() and eval() to cmd.
  • Field for the return value.
  • Other metadata such as runtime and seed. Need to think about organization.
@wlandau
Copy link
Collaborator Author

wlandau commented Mar 29, 2020

should track pre-build and post-build metadata separately

@wlandau
Copy link
Collaborator Author

wlandau commented Mar 30, 2020

Almost done. Need #5.

@wlandau
Copy link
Collaborator Author

wlandau commented Mar 31, 2020

Need to decompose fields.

  • key
  • cmd (already has subfields)
  • file (already has subfields)
  • result
    • value
    • seconds
    • warnings
    • error
  • settings
    • format
    • seed

@wlandau
Copy link
Collaborator Author

wlandau commented Mar 31, 2020

result and settings should be classes of their own.

@wlandau
Copy link
Collaborator Author

wlandau commented Mar 31, 2020

After that is done, a target should be able to save itself without a data store class. Only the metadata needs to be a class, not the whole store.

@wlandau
Copy link
Collaborator Author

wlandau commented Apr 2, 2020

Done as a general issue. Offloading to sub-issues.

@wlandau wlandau closed this as completed Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant