Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue errors if a user tries to uses a taxmap option with taxonomy object #47

Closed
4 tasks done
zachary-foster opened this issue May 24, 2017 · 3 comments
Closed
4 tasks done
Assignees
Milestone

Comments

@zachary-foster
Copy link
Collaborator

zachary-foster commented May 24, 2017

There are 4 functions that have been moved from taxmap to taxonomy:

  • filter_taxa
  • arrange_taxa
  • sample_n_taxa
  • sample_frac_taxa

These have a few options specific to taxmap. For the purposes of DRY, I will try to have the full functions in taxonomy and check the class used before allowing the options specific to taxmap to be used.

@zachary-foster zachary-foster self-assigned this May 24, 2017
@sckott
Copy link
Contributor

sckott commented May 24, 2017

this is for first CRAN push, yes?

@zachary-foster
Copy link
Collaborator Author

I think so, I expect to have it done today. Now there is only one version of those functions in Taxonomy (not in Taxmap), so its actually a little less complicated than overwriting the functions in taxmap like I did originally. Just need to move things around and add some ifs and warnings.

@sckott
Copy link
Contributor

sckott commented May 24, 2017

okay, will mark with the milestone

@sckott sckott added this to the v0.1 milestone May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants