Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return actual httr request object in response #132

Closed
sckott opened this issue Dec 19, 2019 · 1 comment
Closed

return actual httr request object in response #132

sckott opened this issue Dec 19, 2019 · 1 comment
Labels
Milestone

Comments

@sckott
Copy link
Collaborator

sckott commented Dec 19, 2019

We should try to give back a request object like httr gives in the response. Right now we have request class on the first call (a real http request), but then a RequestSignature on all subsequent calls

library("vcr")
vcr_configure(dir = tempdir())

invisible(use_cassette("test", {
    b <- httr::GET("https://httpbin.org/get")
}))
class(b$request)
#> [1] "request"

invisible(use_cassette("test", {
    b <- httr::GET("https://httpbin.org/get")
}))
class(b$request)
#> [1] "RequestSignature" "R6"
@sckott sckott added the httr label Dec 19, 2019
@sckott
Copy link
Collaborator Author

sckott commented Dec 19, 2019

probably not a high priority - i imagine most users don't do much with $request in the response object

@sckott sckott changed the title httr request object returned in response return actual httr request object in response Dec 20, 2019
@sckott sckott added this to the v0.6 milestone Dec 1, 2020
@sckott sckott closed this as completed in b134745 Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant