Changes related on yardstick 1.2.0 release #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since {yardstick} is now on CRAN, there are a couple of things that can be done, to improve {waywiser} and bring it up to date.
metric_reframer()
to use a for-loop instead ofdplyr::reframe()
see don't use dplyr::summarize() in numeric_metric_summarizer() tidymodels/yardstick#405 for more infoerror_call
sThe last two set of changes now mean that you get more informative errors :D
there might be a failed test or two left over. I hope you are able to resolve those by yourself :)