Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in java_check #15

Closed
Libum opened this issue Sep 25, 2017 · 1 comment
Closed

Bug in java_check #15

Libum opened this issue Sep 25, 2017 · 1 comment

Comments

@Libum
Copy link

Libum commented Sep 25, 2017

Hi, I think I noticed a small bug in java_check function from selenium.R:

java_check <- function(){
  javapath <- Sys.which("java")
  if(identical(javapath, "")){
    stop("PATH to JAVA not found. Please check JAVA is installed.")
  }
  javapath
}

Sys.which always returns named vector, so condition in if statement always evaluates to False, even if Java is not defined in the PATH. It resulted in not very informative error, when I tried to run selenium() function on machine with no Java in the system path.

@johndharrison
Copy link
Member

johndharrison commented Sep 26, 2017

Thanks @Libum for spotting this. Fixed ba3683d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants