Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find_nearby_stations() includes closed BOM stations even when "include_closed == FALSE" #36

Closed
adamhsparks opened this issue Aug 7, 2023 · 0 comments
Closed

find_nearby_stations() includes closed BOM stations even when "include_closed == FALSE" #36

adamhsparks opened this issue Aug 7, 2023 · 0 comments
Assignees
@adamhsparks
Labels
bug Something isn't working

Comments

@adamhsparks
Copy link
Member

adamhsparks commented Aug 7, 2023 •
edited

Describe the bug
find_nearby_stations() includes closed BOM stations even when include_closed = FALSE

To Reproduce

library(weatherOz)

me_stn <- find_nearby_stations(
    station_code = "ME",
    distance_km = 10,
    api_key = Sys.getenv("DPIRD_API_KEY"),
    which_api = "all", include_closed = FALSE
)

The station 010093 closed in 2015 but is listed as the closest.

Expected behavior
Closed BOM stations should not be included.
@adamhsparks adamhsparks added the bug Something isn't working label Aug 7, 2023
@adamhsparks adamhsparks self-assigned this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamhsparks adamhsparks

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adamhsparks