Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Directory level contributor scanning #34

Closed
chartgerink opened this issue Jan 30, 2024 · 1 comment
Closed

Feature: Directory level contributor scanning #34

chartgerink opened this issue Jan 30, 2024 · 1 comment

Comments

@chartgerink
Copy link
Contributor

Hi 👋 As mentioned in #33, I love this package. Been using all-contributors for years and this is just a fantastic package for recognizing contributions! 😊

In my work, I was trying to create one big contributor list across an entire organization, whose repo's I'd cloned locally already. To that end, I needed to scan all the repositories living in a specific folder. I fiddled around with the main function and was able to do this locally, with relatively little effort (it ain't pretty though!).

I wondered whether a more refined implementation of that feature would be of interest to the package? I was imagining something along the lines of add_contributors_dir() but have not thought about it too deeply --- I wanted to touch base with you and see whether this would be a worthwhile contribution first 😊

@chartgerink chartgerink changed the title Feature: Directory level contributor list Feature: Directory level contributor scanning Jan 30, 2024
@mpadge
Copy link
Member

mpadge commented Jan 30, 2024

Sounds great to me! An even easier option would be just to modify the add_contributors() function. Best idea might be to just update the repo parameter to accept multiple values. Most current code in that function could then be ported off to a sub-function, add_contributors_one_repo or something, and then the main function could loop over repos and collate everything. The destination files can be explicitly specified anyway, so that would probably all work.

It'd be great if you wanted to submit a PR with something along those lines 👍 thanks again 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants