Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: fix es_ES that can give two same last names #34

Closed
sckott opened this issue Mar 9, 2017 · 1 comment
Closed

review: fix es_ES that can give two same last names #34

sckott opened this issue Mar 9, 2017 · 1 comment
Labels
review
Milestone
v0.1

Comments

@sckott
Copy link
Collaborator

sckott commented Mar 9, 2017

Under the es_ES locale setting, it looks like many names get the same last name twice. Should this instead be sampling two different names from the last names vector and then putting them together?
@sckott sckott added the review label Mar 9, 2017
@sckott sckott mentioned this issue Mar 9, 2017
Closed
13 tasks
@sckott
Copy link
Collaborator Author

sckott commented Mar 28, 2017

donein 997e803

@sckott sckott closed this as completed Mar 28, 2017
@sckott sckott modified the milestone: v0.1 May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
v0.1
Development

No branches or pull requests
1 participant
@sckott