Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[roq-api] order_id must be uint64_t #377

Closed
thraneh opened this issue Aug 4, 2023 · 0 comments
Closed

[roq-api] order_id must be uint64_t #377

thraneh opened this issue Aug 4, 2023 · 0 comments
Labels
Milestone

Comments

@thraneh
Copy link
Contributor

thraneh commented Aug 4, 2023

We previously used uint32_t with an effective range of 24 bits.

Some use cases involve high throughput and working orders across all restarts. It was deemed that ~16M possible order_id's would not be enough.

We have therefore decided to make the type uint64_t with an effective range of 48 bits.

Furthermore, we will change the gateways to reset max_order_id to startup time (wall clock) upon restarts.

This allows for the uniqueness and range that we are looking for.

This change will feed into the use of ClOrdID. Another issue will be opened to track the progress of that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant