Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[roq-binance-futures] Initial PositionUpdate incorrectly used notional #455

Closed
thraneh opened this issue Apr 9, 2024 · 0 comments
Closed

[roq-binance-futures] Initial PositionUpdate incorrectly used notional #455

thraneh opened this issue Apr 9, 2024 · 0 comments
Labels
bug Something isn't working high priority support
Milestone
1.0.1

Comments

@thraneh
Copy link
Contributor

thraneh commented Apr 9, 2024

notional = price * position_amt

We should be using position_amt
@thraneh thraneh added bug Something isn't working high priority support labels Apr 9, 2024
@thraneh thraneh added this to the 1.0.1 milestone Apr 9, 2024
@thraneh thraneh closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high priority support
Milestone
1.0.1
Development

No branches or pull requests
1 participant
@thraneh