Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.distinct is inefficient #44

Open
mkeskells opened this issue Jan 30, 2018 · 2 comments
Open

.distinct is inefficient #44

mkeskells opened this issue Jan 30, 2018 · 2 comments
Assignees
@pkukielka
Labels
PRed
Milestone
2.12.5

Comments

@mkeskells
Copy link
Collaborator

similar to #26 but specifically for distinct

stats (https://github.com/pkukielka/scala-collections-usage/blob/master/run2/traced.csv) show distinct is called many times on empty collections, and there are many optimisations that can be baked off against each other

127284	scala.collection.immutable.Nil$::distinct()Ljava/lang/Object;
@mkeskells
Copy link
Collaborator Author

made a start in https://github.com/rorygraves/scalac_perf/tree/mike/2.12.x_distinct - just a few ideas

@mkeskells mkeskells added the PRed label Mar 12, 2018
@mkeskells mkeskells added this to the 2.12.5 milestone Mar 12, 2018
@mkeskells
Copy link
Collaborator Author

@pkukielka can update this issue
reference the PRs and update the milestones
Is this merged yet? to 2.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkukielka pkukielka

Labels
PRed
Projects
None yet
Milestone
2.12.5
Development

No branches or pull requests
2 participants
@pkukielka @mkeskells