Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vector.equals uses iterators. Could be optimised #75

Open
mkeskells opened this issue Jun 21, 2018 · 0 comments
Open

Vector.equals uses iterators. Could be optimised #75

mkeskells opened this issue Jun 21, 2018 · 0 comments
Assignees
@mkeskells
Labels
collections Easy PRed
Milestone
2.12.7

Comments

@mkeskells
Copy link
Collaborator

If a Vector is compared to another Vector (or some other collection that efficiently implements length and apply) then we should prefer that mechanism, with a default/fallback to the existing iterator mechanism

This issue was inspired by an observed issue in a production application

We should include a benchmark in any fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkeskells mkeskells

Labels
collections Easy PRed
Projects
None yet
Milestone
2.12.7
Development

No branches or pull requests
1 participant
@mkeskells