Add support for mimic joints. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
destogl
force-pushed
the
feature-add-support-for-mimic-joints
branch
from
8298604
to
f48ce0c
Compare
ahcorde
requested changes
Feb 8, 2022
|
friendly ping @destogl |
|
Sorry, didn't manage to go back to it. Do you have any bandwidth to finish this. I will need few more days until I manage to come to it. |
|
No worries, it was just a reminder |
livanov93
force-pushed
the
feature-add-support-for-mimic-joints
branch
from
f48ce0c
to
379fd22
Compare
|
@ahcorde Friendly ping for a review. |
destogl
commented
Apr 15, 2022
livanov93
force-pushed
the
feature-add-support-for-mimic-joints
branch
from
e9ab9ab
to
bb465b3
Compare
ahcorde
requested changes
Aug 15, 2022
Signed-off-by: Denis Štogl <denis@stogl.de>
livanov93
force-pushed
the
feature-add-support-for-mimic-joints
branch
from
ace92bc
to
ce69cb6
Compare
|
@destogl please change base branch to |
ahcorde
requested changes
Aug 26, 2022
destogl
changed the title
ahcorde
approved these changes
Sep 1, 2022
2 tasks
Closed
livanov93
added a commit
to livanov93/ign_ros2_control
that referenced
this pull request
Feb 22, 2023
Signed-off-by: Denis Štogl <denis@stogl.de> Co-authored-by: Lovro <lovro.ivanov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the same support for mimic joints as in ros-controls/gazebo_ros2_control#107.
The code is just slightly adjusted to work with Ignition.
@ahcorde: I have a question regarding writing position commands to the simulator from the plugin. It is a bit different from for velocity and effort. Is this wrong? I have adjusted this in 8298604.
Moreover, I have a compilation issue with this code, but there is no error output about it. Do you have any idea?