-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tricycle demo #80
Add tricycle demo #80
Conversation
I haven't tested it yet because ignition crashes for me on master. Can you please confirm whether you are able to run the diff drive demo on master? I'm using a rolling docker image:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this line is wrong
https://github.com/ros-controls/gz_ros2_control/blob/master/ign_ros2_control/src/ign_system.cpp#L294
it should be
this->dataPtr->joints_[j].joint_velocity = initial_velocity;
can you try it?
Hallelujah, works now. I added your fix to this PR |
Ah, just noticed this #81, will remove fix from this PR |
ab3c330
to
992c39d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comment, otherwise LGTM
Similar to https://github.com/ros-controls/gazebo_ros2_control/pull/145/files