Fix Docker entrypoint and add launch CLI to dependencites #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
requested changes
Sep 12, 2022
ahcorde
approved these changes
Sep 12, 2022
livanov93
pushed a commit
to livanov93/ign_ros2_control
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to run the docker container, I found out that the ROS_DISTRO variable is not set. Since throughout the whole Dockerfile it is hard-coded to
rollingI did the same for theentrypoint.shfile.There was also missing
ros2launchas a dependency insideign_ros2_control_demos. Without that, I was unable to run the demos inside the Docker. Theros2 launchcommand was unavailable.