Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup tests for controllers to not call on_configure if on_init fails #417

Open
destogl opened this issue Aug 17, 2022 · 2 comments
Open

Cleanup tests for controllers to not call on_configure if on_init fails #417

destogl opened this issue Aug 17, 2022 · 2 comments
Labels
good first issue good second issue help wanted

Comments

@destogl
Copy link
Member

destogl commented Aug 17, 2022

It guards against on_configure being called and resulting in a segfault in the case where on_init failed and param_listener_ is not yet valid.

Originally posted by @tylerjw in #395 (comment)

Then also cleanup the code from guards.
@jaron-l
Copy link
Member

jaron-l commented Aug 18, 2022

Isn't this a duplicate of #405?

@destogl
Copy link
Member Author

destogl commented Aug 23, 2022

It's actually inverse and expected behavior. Those will be resolved soon, when we merge all Parameters stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue good second issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@destogl @jaron-l