Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task 7: There is already some implementation in the task branch #15

Closed
Xi-HHHM opened this issue Feb 26, 2023 · 1 comment
Closed

Task 7: There is already some implementation in the task branch #15

Xi-HHHM opened this issue Feb 26, 2023 · 1 comment
Assignees
@destogl

Comments

@Xi-HHHM
Copy link
Collaborator

Xi-HHHM commented Feb 26, 2023

The description tells us to implement the hardware_interface from scratch and adjust the URDF file.

However, there seem to be some implementations in the task branch 7-robot-hardware-interface/task. If that is not expected, we may want to remove the following files:

  • controlko_hardware_interface/include/controlko_hardware_interface/rrbot_hardware_interface.hpp
  • controlko_hardware_interface/src/rrbot_hardware_interface.cpp

For more details, please see the comparison: 7-robot-hardware-interface/task...7-robot-hardware-interface/solution#diff-f8f14cecf04745bc6fe784bf25f31897dac3189eb240d11e3900fc1182fd17c6
@Xi-HHHM Xi-HHHM mentioned this issue Feb 26, 2023
Closed
@destogl
Copy link
Member

destogl commented Feb 28, 2023

Duplication of #14

@destogl destogl closed this as completed Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@destogl destogl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@destogl @Xi-HHHM