Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if packages are found in the repo which are not listed in the gbprepo #34

Closed
tfoote opened this issue Oct 6, 2012 · 5 comments
Closed
Milestone

Comments

@tfoote
Copy link
Member

tfoote commented Oct 6, 2012

I almost added a meta-package but didn't list it in the gbprepo and it wouldn't have been built into debian packages.

This might be good to display next to the list of packages to be built.

@tfoote
Copy link
Member Author

tfoote commented Oct 7, 2012

If you haven't added things to the gbp you get an error like below which is not accurate or helpful. Manually running that command passes, but the next tag fails.

Reading control template from resources/em/control.em
Reading changelog template from resources/em/changelog.em
Reading rules template from resources/em/rules.cmake.em
Reading gbp.conf template from resources/em/gbp.conf.em
+ cd . && git add debian
+ cd . && git commit -m + Creating debian mods for distro: quantal, rosdistro: groovy, upstream version: 1.9.15
[debian/groovy/urdf_parser be22856] + Creating debian mods for distro: quantal, rosdistro: groovy, upstream version: 1.9.15
 1 file changed, 1 insertion(+), 1 deletion(-)
tag: debian/ros-groovy-urdf-parser_1.9.15-0_quantal
+ cd . && git tag -f debian/ros-groovy-urdf-parser_1.9.15-0_quantal -m Debian release 1.9.15
Updated tag 'debian/ros-groovy-urdf-parser_1.9.15-0_quantal' (was 0000000)
[git-bloom-release]: Calling 'git-bloom-generate-debian -t debian/groovy/urdf_parser groovy --debian-revision 0 --do-not-update-rosdep' returned exit code 0
[git-bloom-release]: Command git-bloom-generate-debian-all failed with retcode: 1

@wjwwood
Copy link
Contributor

wjwwood commented Jun 12, 2013

@tfoote Is this still valid?

@tfoote
Copy link
Member Author

tfoote commented Jun 12, 2013

I don't know if you've taken it up in recent modifications. The new use case would be if it's not listed in the rosdistro but is in the repo.

Packages:
foo:
bar:

But in the repo is
repo/
foo
bar
baz

@wjwwood
Copy link
Contributor

wjwwood commented Jun 12, 2013

Ok, I can add this check, but only when using bloom-release, because all other bloom commands have no notion of the rosdistro file.

Also, sometimes you want to explicitly do this, e.g. you might want to exclude test_foo from your rosdistro file entry.

@wjwwood
Copy link
Contributor

wjwwood commented Jun 20, 2013

This is automatically handled by the pull request mechanism, and you can now explicitly ignore packages in bloom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants