Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map server service to change map #239

Closed
SteveMacenski opened this issue Oct 24, 2018 · 2 comments
Closed

map server service to change map #239

SteveMacenski opened this issue Oct 24, 2018 · 2 comments
Assignees
Labels
2 - Medium Medium Priority enhancement New feature or request

Comments

@SteveMacenski
Copy link
Member

There's a fork here (ros-planning/navigation#461) that implements but stalled out waiting for folks to accept message files.

@mkhansenbot mkhansenbot added the enhancement New feature or request label Oct 25, 2018
@mkhansenbot mkhansenbot added this to To do in Navigation 2 Kanban via automation Oct 25, 2018
@mkhansenbot
Copy link
Collaborator

This is good, but shouldn't it be "set map" instead of "change map". I'm just thinking it should use consistent getter / setter methods since we already have a "get map" service. I know you didn't write the PR but let me know your thoughts on that. I

@SteveMacenski
Copy link
Member Author

I think set map would work too. Personally I also prefer change map as it implies you're going from current map -> new map since the map server can only run with a given file already loaded. Set map (to me) doesn't have the same connotations that you're changing the map of choice. This would also be just diction I'm used to from my own internal APIs.

Either would work.

@mkhansenbot mkhansenbot added the 2 - Medium Medium Priority label Nov 12, 2018
@mkhansenbot mkhansenbot added this to the D Turtle Release milestone Dec 3, 2018
@crdelsey crdelsey moved this from Incoming Issues to Other Issues in Navigation 2 Kanban Jan 22, 2019
@crdelsey crdelsey removed this from the D Turtle Release milestone Jan 29, 2019
@crdelsey crdelsey mentioned this issue Oct 11, 2019
16 tasks
@SteveMacenski SteveMacenski added this to the Tiny Ticket Sprint milestone Oct 18, 2019
@mkhansenbot mkhansenbot self-assigned this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - Medium Medium Priority enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants