Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete nav2_controller_example #263

Closed
crdelsey opened this issue Oct 30, 2018 · 2 comments
Closed

Delete nav2_controller_example #263

crdelsey opened this issue Oct 30, 2018 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@crdelsey
Copy link
Contributor

Now that the DWB controller is working, we can delete nav2_controller_example.

When this is done, the reference to the controller should also be deleted from nav2_bringup/launch/core.launch.py

This example controller will eventually be replaced by a functional carrot controller as mentioned in #202

@crdelsey crdelsey self-assigned this Oct 30, 2018
@crdelsey crdelsey added this to the October 2018 milestone Oct 30, 2018
@crdelsey crdelsey added the bug Something isn't working label Oct 30, 2018
@crdelsey crdelsey modified the milestones: October 2018, November 2018 Oct 30, 2018
@crdelsey crdelsey added this to To do in Navigation 2 Kanban via automation Oct 30, 2018
@SteveMacenski
Copy link
Member

I'm fairly certain this was done already in a recently merged PR

@crdelsey
Copy link
Contributor Author

You're right! I think that was the next commit after I submitted this :-)

Navigation 2 Kanban automation moved this from To do to Done Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

2 participants