Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SetParameter Launch API to set the yaml filename for map_server #3149

Closed
SteveMacenski opened this issue Aug 25, 2022 · 2 comments
Closed
Labels

Comments

@SteveMacenski
Copy link
Member

SteveMacenski commented Aug 25, 2022

Would let us remove the RewrittenYaml remappings entirely and let us remove the requirement of a bogus yaml_filename entry in the yaml file to be overwritten. Now, it could just not be present at all and that would be fine. Just need to make sure that this is set only for the map_server node, which should be straight forward.

See #3131 for a motivating example and fixes #3111 to be less quirky @superseppl. Thanks @tonynajjar once again for a timely PR that helps fix another problem

Note that we should also remove the note I added to the navigation.ros.org configuration for map server explaining that yaml_filename is strictly required.

@stevedanomodolor
Copy link
Contributor

@SteveMacenski I can try it this weekend

@SteveMacenski
Copy link
Member Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants