Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slow / safety zones to map #404

Closed
mkhansenbot opened this issue Dec 3, 2018 · 6 comments
Closed

Add Slow / safety zones to map #404

mkhansenbot opened this issue Dec 3, 2018 · 6 comments
Labels
2 - Medium Medium Priority enhancement New feature or request

Comments

@mkhansenbot
Copy link
Collaborator

Feature request

Slow / safety zones

Feature description

User should be able to specify slow/safety zones on a map via a GUI and/or via a file (XML? YAML?) Zones can be limited to rectangles to begin with

Implementation considerations

Should be possible to do this with a costmap layer, but planner support may be required also

@mkhansenbot mkhansenbot added the enhancement New feature or request label Dec 3, 2018
@mkhansenbot mkhansenbot added this to the D Turtle Release milestone Dec 3, 2018
@mkhansenbot mkhansenbot added this to To do in Navigation 2 Kanban via automation Dec 3, 2018
@mkhansenbot mkhansenbot added the 1 - High High Priority label Dec 7, 2018
@crdelsey crdelsey moved this from Incoming Issues to High Priority Issues in Navigation 2 Kanban Jan 22, 2019
@crdelsey crdelsey added 2 - Medium Medium Priority and removed 1 - High High Priority labels Jan 29, 2019
@crdelsey crdelsey moved this from High Priority Issues to Medium Priority Issues in Navigation 2 Kanban Jan 29, 2019
@crdelsey crdelsey removed this from the D Turtle Release milestone Jan 29, 2019
@crdelsey crdelsey mentioned this issue Oct 11, 2019
16 tasks
@mkhansenbot mkhansenbot added this to the F Turtle Release milestone Dec 6, 2019
@mkhansenbot mkhansenbot added this to Incoming Issues in Navigation 2 Kanban via automation Dec 6, 2019
@mkhansenbot mkhansenbot reopened this Dec 6, 2019
Navigation 2 Kanban automation moved this from Incoming Issues to In progress Dec 6, 2019
@SteveMacenski
Copy link
Member

This is covered by #1263

@mkhansenbot
Copy link
Collaborator Author

I don't think so, that says traffic lanes in the description.

@SteveMacenski
Copy link
Member

I think the discussion in the ticket describes a path forward that makes them all the exact same problem description, with a single operational difference.

This to me then signals this is a great candidate for a generic costmap layer with plugins for how to handle cost. Which is the same as traffic lanes, keep out, slow down, etc

@mkhansenbot
Copy link
Collaborator Author

I don't disagree that the implementations may be similar and even overlapping, however the 'feature' from a users and robots perspective is different. This is why they have separate issues filed.

@SteveMacenski
Copy link
Member

I don't think they should be separate issues because of how closely they relate that in the process of implementing 1, you should implement them all since they share 90% of the code. This also makes [whomever] is doing that at the time think about design so that these are extendable and not just 1-offs.

I think adding a costmap-filter-like plugin interface that can be used to make these features would be and invaluable asset. Then as there are more tasks for spatial-setting-scheduling all the tools are there already. I doubt you and I could come up with an exhaustive list of all the things someone might want to do with this kind of interface so its more important to me to have it built in a way that is extendable like the costmap-plugins for new usecases. This is the main reason I put them in the same ticket so that someone wouldn't just make a one-off executable or layer

@SteveMacenski SteveMacenski added this to To do in V1.0.0 via automation Jan 31, 2020
@SteveMacenski SteveMacenski moved this from To do Features to In progress in V1.0.0 Feb 6, 2020
@SteveMacenski SteveMacenski removed this from In progress in V1.0.0 May 13, 2020
@SteveMacenski
Copy link
Member

#1263 covers and underway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - Medium Medium Priority enhancement New feature or request
Projects
No open projects
Navigation 2 Kanban
  
In progress
Development

No branches or pull requests

3 participants