Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RCLCPP_INFO messages #59

Closed
mkhansenbot opened this issue Sep 5, 2018 · 4 comments
Closed

Fix RCLCPP_INFO messages #59

mkhansenbot opened this issue Sep 5, 2018 · 4 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@mkhansenbot
Copy link
Collaborator

Right now all the RCLCPP_INFO messages look like this one for example:
RCLCPP_INFO(get_logger(), "MissionExecutor::~MissionExecutor")

Let's change these to something more useful to the end user. For example, this one instead could be "Shutting down Mission Executor".

@mkhansenbot mkhansenbot added the bug Something isn't working label Sep 5, 2018
@mkhansenbot mkhansenbot added this to the October 2018 milestone Sep 5, 2018
@mkhansenbot mkhansenbot added this to To do in Navigation 2 Kanban via automation Sep 5, 2018
@mjeronimo mjeronimo self-assigned this Sep 26, 2018
@mjeronimo mjeronimo moved this from To do to In progress in Navigation 2 Kanban Oct 5, 2018
@mjeronimo mjeronimo moved this from In progress to To do in Navigation 2 Kanban Oct 5, 2018
@mjeronimo
Copy link

We've got lots of messages in the code that are for ourselves (developers working on the application) or other developers using this code. Is this suggesting that all of our messages should be for a non-developer end-user? The traces reference are for the initial stages of development where we want to ensure that everything is created and shutdown properly.

@mkhansenbot
Copy link
Collaborator Author

For debug only messages, we can change them to RCLCPP_DEBUG() calls. See here:
https://github.com/ros2/ros2/wiki/Logging

Everything else (INFO, WARN, ERROR) should provide clear messages to the user.

@mjeronimo mjeronimo added the help wanted Extra attention is needed label Oct 18, 2018
@SteveMacenski
Copy link
Member

I'm going to handle this tonight

@mkhansenbot
Copy link
Collaborator Author

@SteveMacenski - thanks for picking this up!

Navigation 2 Kanban automation moved this from To do to Done Oct 23, 2018
ghost referenced this issue in logivations/navigation2 Mar 7, 2022
* Added NarrowPreApproach Action server.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
No open projects
Development

No branches or pull requests

3 participants