Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -Werror flag to CMakeLists.txt files #68

Closed
mkhansenbot opened this issue Sep 7, 2018 · 1 comment
Closed

Add -Werror flag to CMakeLists.txt files #68

mkhansenbot opened this issue Sep 7, 2018 · 1 comment
Assignees
@mkhansenbot
Labels
enhancement New feature or request
Projects
Navigation 2 Kanban
Milestone
September 2018

Comments

@mkhansenbot
Copy link
Collaborator

mkhansenbot commented Sep 7, 2018 •
edited by crdelsey
Loading

To ensure we are warning free, we should add the -Werror flag to our CMakeLists.txt files.
@mkhansenbot mkhansenbot added this to To do in Navigation 2 Kanban via automation Sep 7, 2018
@mkhansenbot mkhansenbot added this to the September 2018 milestone Sep 7, 2018
@mkhansenbot mkhansenbot mentioned this issue Sep 13, 2018
Closed
@mkhansenbot mkhansenbot added task enhancement New feature or request and removed task labels Sep 17, 2018
@crdelsey crdelsey changed the title Add -Werr flag to CMakeLists.txt files Add -Werror flag to CMakeLists.txt files Sep 19, 2018
@mkhansenbot mkhansenbot mentioned this issue Sep 24, 2018
Merged
@mkhansenbot mkhansenbot self-assigned this Sep 25, 2018
@mkhansenbot
Copy link
Collaborator Author

This is merged in #96

Navigation 2 Kanban automation moved this from To do to Done Sep 25, 2018
ghost referenced this issue in logivations/navigation2 Mar 7, 2022
@andriimaistruk
AGVFM-415 Use goal_checker_id in FollowPath to specify target accuracy (
d65a876 
#68)

* change interface

* merge changes from main remote branch related to goal_checker_id

* fix indent and default goal_checker_ids

* fix typo

* backward compat for goals with no goal_checker_id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkhansenbot mkhansenbot

Labels
enhancement New feature or request
Projects
No open projects
Navigation 2 Kanban
  
Done
Milestone
September 2018
Development

No branches or pull requests
1 participant
@mkhansenbot