Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Costmap 2D] Add a system test that includes the voxel layer #955

Closed
crdelsey opened this issue Jul 19, 2019 · 6 comments
Closed

[Costmap 2D] Add a system test that includes the voxel layer #955

crdelsey opened this issue Jul 19, 2019 · 6 comments
Assignees
Labels
2 - Medium Medium Priority

Comments

@crdelsey
Copy link
Contributor

Feature request

Feature description

The voxel layer is part of the nav stack but is untested. A system test is needed that includes the voxel layer.

@crdelsey crdelsey added this to the July 2019 milestone Jul 19, 2019
@crdelsey crdelsey added the 2 - Medium Medium Priority label Jul 19, 2019
@crdelsey crdelsey mentioned this issue Jul 19, 2019
42 tasks
@SteveMacenski
Copy link
Member

FYI: adding in a 3D sensor into gazebo is very heavy I would recommend only working from bag files for this.

You'll need to run this on a very expensive tower to get the 3D sensors stuff in gazebo running at any reasonable rate

@crdelsey
Copy link
Contributor Author

We've already got some tests that are manually run (those tests that verify our dependencies are clean before releasing). This and others could be in that category. In that case, it probably doesn't matter how long it takes. That said, the faster we can make the test the better so long as it covers what we need it to cover

@SteveMacenski
Copy link
Member

Got it, maybe we just setup a dummy 3D sensor that's just super low resolution or low FOV so that we minimize its impact in CI

@crdelsey crdelsey modified the milestones: July 2019, E Turtle Release Jul 22, 2019
@SteveMacenski SteveMacenski changed the title Add a system test that includes the voxel layer [Costmap 2D] Add a system test that includes the voxel layer Aug 8, 2019
@yathartha3 yathartha3 self-assigned this Aug 22, 2019
@yathartha3
Copy link
Contributor

@orduno Here is the issue for Voxel Layer.

@SteveMacenski
Copy link
Member

@crdelsey do you consider hand testing & validating the voxel layer through #1291 in the spirit of completing this ticket?

@crdelsey
Copy link
Contributor Author

Yes. Let's close this as resolved by #1291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - Medium Medium Priority
Projects
None yet
Development

No branches or pull requests

3 participants