Kinematics solver deprecation warning always showing

[mikramarc]

Description

The deprecation warning from here:
https://github.com/ros-planning/moveit/blob/master/moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp#L349
is ALWAYS showing, no matter if the .../kinematics_solver_attempts parameter exists or not.

Your environment

• ROS Distro: Melodic
• OS Version: Ubuntu 18.04
• Source or Binary build?
  Source build, master branch

Steps to reproduce

Repreduce by running kinematics plugin loader without kinematics_solver_attempts param in the parameter server.

Expected behaviour

If the kinematics_solver_attempts not present on the parameter server, the warning should not appear.

Actual behaviour

Warning ALWAYS appearing, no matter if param exists or not.

Backtrace or Console output

[ WARN] [1580900838.697365071]: Kinematics solver doesn't support #attempts anymore, but only a timeout.
Please remove the parameter '/move_group/right_arm/kinematics_solver_attempts' from your configuration.

[welcome]

Thanks for reporting an issue. Because we're a volunteer community, providing a pull request with suggested changes is always welcomed.

[rhaschke]

Thanks for reporting. I filed a fixing PR: #1876.