Adds missing deps to the package.xml template #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the 'joint_trajectory_controller' and 'gazebo_ros_control' depencenies to the `moveit_setup_assistant` package.xml template. These dependencies are needed for the gazebo simulation.
|
I seem to vaguely remember these were left out on purpose so as to avoid pulling in Gazebo on systems which don't need / want it. |
|
@gavanderhoorn That makes sense, I will also keep them out of the new Noetic panda_moveit_config branch. |
|
You could perhaps add them, but comment them like the That way it would at least be clear they weren't omitted by mistake. |
Codecov Report
@@ Coverage Diff @@
## master #2839 +/- ##
==========================================
+ Coverage 60.81% 60.82% +0.02%
==========================================
Files 366 366
Lines 31717 31717
==========================================
+ Hits 19286 19290 +4
+ Misses 12431 12427 -4
Continue to review full report at Codecov.
|
rickstaa
force-pushed
the
adds_missing_setup_assistant_deps
branch
from
3de6982
to
38e60f2
Compare
|
@gavanderhoorn Good idea. I added them, but now commented with a note above. |
rhaschke
approved these changes
Aug 25, 2021
moveit_setup_assistant/templates/moveit_config_pkg_template/package.xml.template
Outdated
Show resolved
Hide resolved
|
@rhaschke Your right, thanks for improving my comment. |
…ckage.xml.template Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
rhaschke
approved these changes
Aug 26, 2021
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 26, 2021
This commit adds several missing package dependencies. These package dependencies were commented to prevent installing gazebo be default. It was merged to be consistent with the 'moveit_setup_assistant' (see moveit/moveit#2839).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 26, 2021
This commit adds several missing package dependencies. These package dependencies were commented to prevent installing gazebo be default. It was merged to be consistent with the 'moveit_setup_assistant' (see moveit/moveit#2839).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
This commit adds several missing package dependencies. These package dependencies were commented to prevent installing gazebo be default. It was merged to be consistent with the 'moveit_setup_assistant' (see moveit/moveit#2839).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
This commit adds several missing package dependencies. These package dependencies were commented to prevent installing gazebo be default. It was merged to be consistent with the 'moveit_setup_assistant' (see moveit/moveit#2839).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
This commit adds several missing package dependencies. These package dependencies were commented to prevent installing gazebo be default. It was merged to be consistent with the 'moveit_setup_assistant' (see moveit/moveit#2839).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
* Makes ompl planning_adapters argument optional (#27) This commit makes sure that the `planning_adapters` argument in the `ompl_planning_pipeline.launch.xml` launch file is optional. * Fixes custom planner ns bug (#30) This commit fixes a custom planner ns bug that was introduced by the `setup_assistant` (see moveit/moveit#2842). * Adds missing package dependencies This commit adds several missing package dependencies. These package dependencies were commented to prevent installing gazebo be default. It was merged to be consistent with the 'moveit_setup_assistant' (see moveit/moveit#2839).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
This commit adds several missing package dependencies. These package dependencies were commented to prevent installing gazebo be default. It was merged to be consistent with the 'moveit_setup_assistant' (see moveit/moveit#2839).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
This commit adds several missing package dependencies. These package dependencies were commented to prevent installing gazebo be default. It was merged to be consistent with the 'moveit_setup_assistant' (see moveit/moveit#2839).
28 tasks
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
This commit adds several missing package dependencies. These package dependencies were commented to prevent installing gazebo be default. It was merged to be consistent with the 'moveit_setup_assistant' (see moveit/moveit#2839).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
This commit adds several missing package dependencies. These package dependencies were commented to prevent installing gazebo be default. It was merged to be consistent with the 'moveit_setup_assistant' (see moveit/moveit#2839).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
This commit adds several missing package dependencies. These package dependencies were commented to prevent installing gazebo be default. It was merged to be consistent with the 'moveit_setup_assistant' (see moveit/moveit#2839).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 30, 2021
This commit adds several missing package dependencies. These package dependencies were commented to prevent installing gazebo be default. It was merged to be consistent with the 'moveit_setup_assistant' (see moveit/moveit#2839).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the 'joint_trajectory_controller' and 'gazebo_ros_control' dependencies to the
moveit_setup_assistantpackage.xml template. These dependencies are needed for the gazebo simulation.