Skip to content
This repository has been archived by the owner on Nov 13, 2017. It is now read-only.

generate headers in devel space instead of build space #157

Closed
wants to merge 1 commit into from
Closed

generate headers in devel space instead of build space #157

wants to merge 1 commit into from

Conversation

dirk-thomas
Copy link

With the upcoming catkin version passing absolute INCLUDE_DIRS to catkin_package() will be allowed (ros/catkin#600). But since your absolute build space path is temporary downstream packages will fail to find that folder. (Before any absolute path was ignored but there where use cases where it should be possible.)

Instead this pull request generates the header in the devel space which catkin is aware of and assumes that these generated files will be installed by the user (similar as generated message headers).

Please review and test - I haven't even tried to compile the package after the change 馃槈 This fix should be released in Groovy, Hydro and Indigo.

@isucan
Copy link
Contributor

isucan commented Mar 1, 2014

Vincent did this better ;)

@isucan isucan closed this Mar 1, 2014
@dirk-thomas
Copy link
Author

As far as I can see from his patch (8a76161) the folder where the header is generated to is never being added to the include_directories(). My guess would be that it will fail to build when you try an isolated build (without another package e.g. containing messages which will add the devel include folder for you). I guess the farm will tell us when it tries to build the Debian package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants