Skip to content
This repository has been archived by the owner on Nov 13, 2017. It is now read-only.

Shrink window height #105

Merged
merged 2 commits into from
Mar 2, 2015
Merged

Shrink window height #105

merged 2 commits into from
Mar 2, 2015

Conversation

130s
Copy link
Contributor

@130s 130s commented Mar 2, 2015

On computers with smaller display size, the window of setup assistant is too large and the button hides beneath the desktop window. Although by moving into the WorkSpace below on Ubuntu the users still can hit the buttons, not all users can realize that option.

This PR does:

  • changes minimum window height
  • Make MoveIt! logo smaller to allow more free space
  • set scrollable one of the text areas that can get squashed with the new minimum height

I can rebase commits if that's better.

Very first page (left: current, right: this PReq)
moveit_setup_assis_fixedheight_1moveit_setup_assis_new_1

Here the load pane is gone invisible, but either option ("current" or "existing" package) must be chosen to move forward anyway IMO.

After a package is loaded:
moveit_setup_assis_new_2

@hersh
Copy link
Contributor

hersh commented Mar 2, 2015

This looks like a nicer fix to #82 than I made previously, thanks @130s .

hersh added a commit that referenced this pull request Mar 2, 2015
@hersh hersh merged commit 768d996 into moveit:indigo-devel Mar 2, 2015
@130s 130s deleted the fix/windowsize branch August 11, 2015 04:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants