Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activated all hardware by default #143

Merged
merged 1 commit into from
Jul 22, 2022
Merged

activated all hardware by default #143

merged 1 commit into from
Jul 22, 2022

Conversation

mcbed
Copy link
Member

@mcbed mcbed commented Jul 22, 2022

Default activation of hardware names GazeboSystem is very restrictive. Suggestion to set all hardware to available by default.

ahcorde
ahcorde requested changes Jul 22, 2022
View reviewed changes
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linters https://github.com/ros-controls/gazebo_ros2_control/runs/7465981252?check_suite_focus=true

@mcbed
Copy link
Member Author

mcbed commented Jul 22, 2022

Linters https://github.com/ros-controls/gazebo_ros2_control/runs/7465981252?check_suite_focus=true

Fixed

destogl
destogl approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just did this change too :D

@destogl destogl merged commit 98f13bd into ros-controls:master Jul 22, 2022
@destogl destogl mentioned this pull request Jul 22, 2022
Merged
@ahcorde ahcorde mentioned this pull request Jul 22, 2022
Merged
@mcbed mcbed deleted the activate_all_hardware branch July 25, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde requested changes

@destogl destogl destogl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcbed @destogl @ahcorde