Join with the controller manager's executor thread on exit #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a SIGABRT in gzserver when stopping gazebo due to the executor thread being aborted, which triggers a core dump. This patch instead ensures a clean exit, since rclcpp::ok() returns true while gazebo is shutting down.
Note: I'm not sure why the controller manager's node must be removed from the executor, but otherwise the join() will remain blocked and prevent gzserver from stopping even with a SIGTERM.