Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to game_controller_spl #79

Merged
merged 3 commits into from
Jan 20, 2024

Conversation

Flova
Copy link
Contributor

@Flova Flova commented Jan 16, 2024

This PR renames everything to game_controller_spl. We would still need to rename the repo (I don't have the permission).

This makes it consistent with https://github.com/ros-sports/game_controller_hl

Closes #77

@ijnek
Copy link
Member

ijnek commented Jan 18, 2024

Thanks for starting this change @Flova, while the changes look good, these packages are already released and a tik-tok deprecation strategy is necessary to ensure teams that rely on this (there are a few), don't suddenly have code that doesn't work.

Would you be able to add the new packages, but leave the old packages there, and add a deprecation tag in in package.xml, as following?

  <export>
    <build_type>ament_python</build_type>
    <deprecated>
      Please use game_controler_spl. gc_spl will be removed in K-turtle.
    </deprecated>
  </export>

@ijnek ijnek force-pushed the rename_to_game_controller_spl branch from 387ae79 to 5fed722 Compare January 20, 2024 17:01
@ijnek
Copy link
Member

ijnek commented Jan 20, 2024

Due to some complications elsewhere with deprecation of packages, i've gone ahead and rebased and made the changes. Once CI passes, this will be merged.

@ijnek ijnek merged commit 668da93 into ros-sports:rolling Jan 20, 2024
2 checks passed
@ijnek
Copy link
Member

ijnek commented Jan 20, 2024

Thanks for this improvement @Flova !

@Flova Flova deleted the rename_to_game_controller_spl branch January 20, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maybe use game controller instead of gc
2 participants