Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration dialog and wait window setting #41

Merged
merged 4 commits into from
Aug 22, 2022

Conversation

Kettenhoax
Copy link
Contributor

Adds a configuration dialog to set the composition waiting time.
300ms is a good default, but I have had to deal with higher latencies in overlay messages.
Adjusting the waiting time without rebuilding has been convenient.

rqt_image_overlay-waiting_time_cfg

Marcel Zeilinger and others added 2 commits August 19, 2022 12:42
@ijnek
Copy link
Member

ijnek commented Aug 20, 2022

Thanks for the PR @Kettenhoax, this is great!
I didn't know that configuration dialogs existed for rqt_plugins 🤔 , seems quite useful.
I've put my suggestions into a PR against your branch at Kettenhoax#1, so please check it out.

ijnek and others added 2 commits August 21, 2022 06:22
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Ensure window member thread safety, blocking dialog
@ijnek ijnek merged commit 4b2f695 into ros-sports:rolling Aug 22, 2022
@ijnek
Copy link
Member

ijnek commented Aug 22, 2022

Thanks for the contribution! @Kettenhoax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants