Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing pip since 0.3.8 #866

Closed
christian-rauch opened this issue Apr 29, 2024 · 13 comments
Closed

missing pip since 0.3.8 #866

christian-rauch opened this issue Apr 29, 2024 · 13 comments
Labels
bug Something isn't working

Comments

@christian-rauch
Copy link
Contributor

Description

Since 0.3.8 the action fails with pip: command not found.

Expected Behavior

The action continues to work.

Actual Behavior

I am seeing CI failures for workflows that used to work:

Invoking: bash -c,pip freeze
  /usr/bin/bash -c pip freeze
  /usr/bin/bash: line 1: pip: command not found
@christian-rauch christian-rauch added the bug Something isn't working label Apr 29, 2024
@christophebedard
Copy link
Member

Does pip3 work?

@christophebedard
Copy link
Member

Oh, nevermind, that's a command run by the action.

@christophebedard
Copy link
Member

christophebedard commented Apr 29, 2024

Can you provide a link to some CI job logs or provide details about the platform this was run on? Because I didn't see that in CI for the PR that introduced that command.

@christophebedard
Copy link
Member

Also, could you give this a try? #867

Just use: ros-tooling/action-ros-ci@christophebedard/pip-freeze-use-pip3

@christian-rauch
Copy link
Contributor Author

Can you provide a link to some CI job logs or provide details about the platform this was run on? Because I didn't see that in CI for the PR that introduced that command.

I cannot share the workflow but I can confirm that this issue does not appear with 0.3.7, i.e. using ros-tooling/action-ros-ci@0.3.7 instead of ros-tooling/action-ros-ci@v0.3.

@christophebedard
Copy link
Member

Please let me know if #867 works!

@christophebedard
Copy link
Member

There is a potential fix (#867), but I don't know if it works and I can't reproduce myself, so I don't know.

@christophebedard
Copy link
Member

There is a potential fix (#867), but I don't know if it works and I can't reproduce myself, so I don't know.

I merged it and released it as 0.3.10/v0.3. Let me know if it works.

@munseng-flexiv
Copy link

@christophebedard

Hi I use the ros-tooling/action-ros-ci@v0.3 and the bug is still there for pip3. The workflow is here: https://github.com/flexivrobotics/flexiv_ros2/actions/runs/8889927077/job/24409074067

Invoking: bash -c,pip3 freeze
  /usr/bin/bash -c pip3 freeze
  /usr/bin/bash: line 1: pip3: command not found
Error: The process '/usr/bin/bash' failed with exit code 127

@christian-rauch
Copy link
Contributor Author

Hi I use the ros-tooling/action-ros-ci@v0.3 and the bug is still there for pip3.

I can confirm this. The error simply changes to pip3: command not found. I guess the action has to install pip first.

@christophebedard
Copy link
Member

christophebedard commented Apr 30, 2024

The workflow is here: https://github.com/flexivrobotics/flexiv_ros2/actions/runs/8889927077/job/24409074067

Thanks for the link! I see; I then assume you're both not using setup-ros or the setup-ros-docker images. This should work then: #868.

I guess the action has to install pip first.

It's just part of the tools that I thought "had" to be installed, similar to the tools listed here: https://github.com/ros-tooling/action-ros-ci#requirements. However, pip isn't listed there and technically isn't required.

@christophebedard
Copy link
Member

This should work then: #868.

I merged that and released it as 0.3.11/v0.3. I hope it helps. It's getting late here, so I'll check again when I wake up.

@christian-rauch
Copy link
Contributor Author

Thanks. The latest version fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants