Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply windows vibility fix changes #5

Merged
merged 7 commits into from
Apr 17, 2020

Conversation

dabonnie
Copy link
Contributor

Add the fixes for windows visibility that were applied to the system_metrics_collector repo

Signed-off-by: Devin Bonnie dbbonnie@amazon.com

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #5 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   25.31%   25.40%   +0.09%     
==========================================
  Files          26       26              
  Lines         806      807       +1     
  Branches      188      188              
==========================================
+ Hits          204      205       +1     
  Misses        435      435              
  Partials      167      167              
Flag Coverage Δ
#unittests 25.40% <ø> (+0.09%) ⬆️
Impacted Files Coverage Δ
...istics_collector/test/collector/test_collector.cpp 46.15% <0.00%> (ø)
...de/libstatistics_collector/collector/collector.hpp 100.00% <0.00%> (ø)
...rage_statistics/test_moving_average_statistics.cpp 58.82% <0.00%> (ø)
...s_collector/collector/metric_details_interface.hpp 100.00% <0.00%> (ø)
...ector/moving_average_statistics/moving_average.hpp 100.00% <0.00%> (ø)
...opic_statistics_collector/received_message_age.hpp 50.00% <0.00%> (ø)
...tatistics_collector/topic_statistics_collector.hpp 100.00% <0.00%> (ø)
...statistics_collector/test_received_message_age.cpp 35.00% <0.00%> (+1.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e329992...b2e0cd3. Read the comment docs.

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
@dabonnie dabonnie marked this pull request as ready for review April 17, 2020 18:26
@prajakta-gokhale prajakta-gokhale merged commit c66252b into master Apr 17, 2020
@dabonnie dabonnie deleted the dabonnie/fix-windows-visibility branch April 17, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants