Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows warning #6

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Fix windows warning #6

merged 1 commit into from
Apr 17, 2020

Conversation

dabonnie
Copy link
Contributor

Signed-off-by: Devin Bonnie dbbonnie@amazon.com

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   25.40%   25.40%           
=======================================
  Files          26       26           
  Lines         807      807           
  Branches      188      188           
=======================================
  Hits          205      205           
  Misses        435      435           
  Partials      167      167           
Flag Coverage Δ
#unittests 25.40% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c66252b...6ae4dc1. Read the comment docs.

@dabonnie dabonnie marked this pull request as ready for review April 17, 2020 20:56
@dabonnie
Copy link
Contributor Author

Manually verified Windows warning is fixed on an instance.

@dabonnie dabonnie merged commit c3751e8 into master Apr 17, 2020
@dabonnie dabonnie deleted the dabonnie/fix-windows-warning branch April 17, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants