Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linter to run on rolling+focal #81

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

emersonknapp
Copy link
Contributor

No description provided.

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp emersonknapp requested a review from a team as a code owner January 20, 2021 23:57
@emersonknapp emersonknapp requested review from Karsten1987 and jaisontj and removed request for a team January 20, 2021 23:57
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #81 (dd2577b) into master (9c57688) will decrease coverage by 23.32%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #81       +/-   ##
===========================================
- Coverage   48.08%   24.75%   -23.33%     
===========================================
  Files        1512       27     -1485     
  Lines       41806      820    -40986     
  Branches    18500      185    -18315     
===========================================
- Hits        20102      203    -19899     
+ Misses       5404      454     -4950     
+ Partials    16300      163    -16137     
Flag Coverage Δ
unittests 24.75% <ø> (-23.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ollector/collector/generate_statistics_message.cpp
...tics_collector/moving_average_statistics/types.cpp
...rc/libstatistics_collector/collector/collector.cpp
...ector/moving_average_statistics/moving_average.hpp
...rc/libstatistics_collector/collector/collector.cpp
...tatistics_collector/topic_statistics_collector.hpp
...ector/moving_average_statistics/moving_average.cpp
...s_collector/test/benchmark/benchmark_iterative.cpp
...ector/moving_average_statistics/moving_average.cpp
...statistics_collector/test_received_message_age.cpp
... and 1505 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c57688...dd2577b. Read the comment docs.

@emersonknapp emersonknapp merged commit 21d6664 into master Jan 21, 2021
@emersonknapp emersonknapp deleted the emersonknapp/update-linter-to-latest branch January 21, 2021 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant