Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest versions of CI actions #92

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Conversation

emersonknapp
Copy link
Contributor

No description provided.

@emersonknapp emersonknapp requested a review from a team as a code owner March 27, 2021 00:30
@emersonknapp emersonknapp requested review from christophebedard and zmichaels11 and removed request for a team March 27, 2021 00:30
@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #92 (4afe920) into master (19ad224) will decrease coverage by 23.48%.
The diff coverage is n/a.

❗ Current head 4afe920 differs from pull request most recent head 0249140. Consider uploading reports for the commit 0249140 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master      #92       +/-   ##
===========================================
- Coverage   48.24%   24.75%   -23.49%     
===========================================
  Files        2277       27     -2250     
  Lines       62920      820    -62100     
  Branches    27935      185    -27750     
===========================================
- Hits        30353      203    -30150     
+ Misses       7954      454     -7500     
+ Partials    24613      163    -24450     
Flag Coverage Δ
unittests 24.75% <ø> (-23.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rage_statistics/test_moving_average_statistics.cpp
...ollector/collector/generate_statistics_message.cpp
...de/libstatistics_collector/collector/collector.hpp
...rc/libstatistics_collector/collector/collector.cpp
...ector/moving_average_statistics/moving_average.hpp
...statistics_collector/test_received_message_age.cpp
...istics_collector/test/collector/test_collector.cpp
...tistics_collector/test_received_message_period.cpp
...opic_statistics_collector/received_message_age.hpp
...ollector/collector/generate_statistics_message.cpp
... and 2270 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ad224...0249140. Read the comment docs.

Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But why not use/upgrade to action-ros-ci@v0.2?

I think the cyclonedds failure for macOS might be related to a recent change on their side.

@emersonknapp
Copy link
Contributor Author

Yeah I had that bison problem when building locally. I think we need to fix it in action ros ci, all the osx builds are failing

@christophebedard
Copy link
Member

Yeah I had that bison problem when building locally. I think we need to fix it in action ros ci, all the osx builds are failing

done 😁 ros-tooling/setup-ros#367

@emersonknapp emersonknapp marked this pull request as draft March 30, 2021 20:56
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp emersonknapp marked this pull request as ready for review March 30, 2021 22:14
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp emersonknapp merged commit b6198d9 into master Mar 31, 2021
@emersonknapp emersonknapp deleted the emersonknapp/action-v01 branch March 31, 2021 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants