This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Update clang-format rules to fit ROS 2 style guide #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: James Smith <james@foxglove.dev>
james-rms
force-pushed
the
jrms/clang-reformat
branch
from
November 22, 2022 02:44
bdabd9c
to
a7bde0f
Compare
james-rms
requested review from
emersonknapp,
jtbandes and
jhurliman
and removed request for
emersonknapp
November 22, 2022 02:45
james-rms
changed the title
Jrms/clang reformat
Update clang-format rules to fit ROS 2 style guide
Nov 22, 2022
Signed-off-by: James Smith <james@foxglove.dev>
james-rms
force-pushed
the
jrms/clang-reformat
branch
from
November 22, 2022 02:57
a7bde0f
to
752e3e2
Compare
Signed-off-by: James Smith <james@foxglove.dev>
james-rms
force-pushed
the
jrms/clang-reformat
branch
from
November 22, 2022 03:16
4160e6e
to
93cbbc9
Compare
rosbag2_storage_mcap/include/rosbag2_storage_mcap/visibility_control.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: James Smith <james@foxglove.dev>
james-rms
force-pushed
the
jrms/clang-reformat
branch
from
November 22, 2022 20:51
78472ce
to
e63a616
Compare
jhurliman
approved these changes
Nov 22, 2022
rosbag2_storage_mcap/include/rosbag2_storage_mcap/message_definition_cache.hpp
Outdated
Show resolved
Hide resolved
emersonknapp
approved these changes
Nov 23, 2022
Signed-off-by: James Smith <james@foxglove.dev>
james-rms
force-pushed
the
jrms/clang-reformat
branch
from
November 23, 2022 02:42
d14fdb2
to
1530bfd
Compare
CI is failing on |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly uses the ROS 2 clang-format rules from here. This also brings rosbag2_storage_mcap into compliance with the ROS 2 style guide.
Some notable changes:
(https://google.github.io/styleguide/cppguide.html#Preprocessor_Directives).
Testing
ament_clang_format .
returns no errors from repo rootament_cpplint .
returns no errors from repo root