Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Update clang-format rules to fit ROS 2 style guide #80

Merged
merged 6 commits into from
Nov 23, 2022

Conversation

james-rms
Copy link
Contributor

@james-rms james-rms commented Nov 22, 2022

Directly uses the ROS 2 clang-format rules from here. This also brings rosbag2_storage_mcap into compliance with the ROS 2 style guide.

Some notable changes:
(https://google.github.io/styleguide/cppguide.html#Preprocessor_Directives).

Testing

  • ament_clang_format . returns no errors from repo root
  • ament_cpplint . returns no errors from repo root

Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: James Smith <james@foxglove.dev>
@james-rms james-rms requested review from emersonknapp, jtbandes and jhurliman and removed request for emersonknapp November 22, 2022 02:45
@james-rms james-rms changed the title Jrms/clang reformat Update clang-format rules to fit ROS 2 style guide Nov 22, 2022
Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: James Smith <james@foxglove.dev>
@james-rms
Copy link
Contributor Author

CI is failing on rolling because update_metadata is not implemented, which I will do in a separate PR.

@james-rms james-rms merged commit e83135e into main Nov 23, 2022
@james-rms james-rms deleted the jrms/clang-reformat branch November 23, 2022 03:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants