This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
Refactor Linux process CPU measurement tests #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
|
Currently passing tests at iteration >1800 |
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
- Coverage 39.26% 38.43% -0.84%
==========================================
Files 37 36 -1
Lines 1444 1405 -39
Branches 869 858 -11
==========================================
- Hits 567 540 -27
Misses 70 70
+ Partials 807 795 -12
Continue to review full report at Codecov.
|
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
zmichaels11
reviewed
Mar 5, 2020
..._metrics_collector/test/system_metrics_collector/test_linux_process_cpu_measurement_node.cpp
Show resolved
Hide resolved
..._metrics_collector/test/system_metrics_collector/test_linux_process_cpu_measurement_node.cpp
Show resolved
Hide resolved
..._metrics_collector/test/system_metrics_collector/test_linux_process_cpu_measurement_node.cpp
Outdated
Show resolved
Hide resolved
zmichaels11
reviewed
Mar 5, 2020
| @@ -77,147 +88,12 @@ class MockLinuxProcessCpuMeasurementNode : public system_metrics_collector:: | |||
| private: | |||
| system_metrics_collector::ProcPidCpuData MakeSingleMeasurement() override | |||
| { | |||
| EXPECT_GT(test_constants::kProcPidSamples.size(), measurement_index_); | |||
| return test_constants::kProcPidSamples[measurement_index_++]; | |||
| EXPECT_GT(kProcPidSamples.size(), measurement_index_); | |||
There was a problem hiding this comment.
Suggested change
| EXPECT_GT(kProcPidSamples.size(), measurement_index_); | |
| ASSERT_GT(kProcPidSamples.size(), measurement_index_); |
Since the following line will index out of bounds if the EXPECT_EQ fails.
There was a problem hiding this comment.
Could use this if the return type was void.
piraka9011
reviewed
Mar 5, 2020
..._metrics_collector/test/system_metrics_collector/test_linux_process_cpu_measurement_node.cpp
Show resolved
Hide resolved
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
zmichaels11
approved these changes
Mar 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves #103 to done
Signed-off-by: Devin Bonnie dbbonnie@amazon.com