Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

[Foxy backport] Fix 'test_subscriber_topic_statistics' must be a valid target name build failure (#175) #176

Merged
merged 1 commit into from Sep 2, 2020

Conversation

jaisontj
Copy link
Contributor

@jaisontj jaisontj commented Sep 1, 2020

Backporting #175 into Foxy

Signed-off-by: Jaison Titus jaisontj@amazon.com
(cherry picked from commit 1c8b25c)

…scope causing colcon build with flag -DBUILD_TESTING=0 to fail. (#175)

Signed-off-by: Jaison Titus <jaisontj@amazon.com>
(cherry picked from commit 1c8b25c)
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #176 into foxy will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             foxy     #176   +/-   ##
=======================================
  Coverage   27.72%   27.72%           
=======================================
  Files          42       42           
  Lines        1847     1847           
  Branches      872      872           
=======================================
  Hits          512      512           
  Misses        534      534           
  Partials      801      801           
Flag Coverage Δ
#unittests 27.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f07cab...a565512. Read the comment docs.

@jaisontj
Copy link
Contributor Author

jaisontj commented Sep 1, 2020

@emersonknapp - please run this CI job
Gist: https://gist.githubusercontent.com/jaisontj/b462fbda3abe7bff4f339fc538881487/raw/1b3eaaca2274d6fcb8117f1d1253cb197ff0047b/ros2.repos
BUILD args: --packages-up-to system_metrics_collector
TEST args: --packages-select system_metrics_collector
Job: ci_launcher

@emersonknapp emersonknapp changed the title Backport to foxy: Fix 'test_subscriber_topic_statistics' must be a valid target name build failure [Foxy backport] Fix 'test_subscriber_topic_statistics' must be a valid target name build failure (#175) Sep 1, 2020
@emersonknapp
Copy link
Contributor

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jaisontj jaisontj merged commit aa80c33 into foxy Sep 2, 2020
@jaisontj jaisontj deleted the backport-175 branch September 2, 2020 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants