This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
Remove DEFAULT_PUBLISH_WINDOW #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabonnie
suggested changes
Dec 2, 2019
system_metrics_collector/src/system_metrics_collector/linux_cpu_measurement_node.hpp
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/linux_memory_measurement_node.hpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/periodic_measurement_node.cpp
Outdated
Show resolved
Hide resolved
mm318
changed the title
dabonnie
suggested changes
Dec 2, 2019
| if (!publish_timer_ && | ||
| publish_period_ != PeriodicMeasurementNode::DEFAULT_PUBLISH_WINDOW) | ||
| { | ||
| if (!publish_timer_ && publish_period_ > std::chrono::milliseconds(0)) { |
There was a problem hiding this comment.
Checking in the start method is too late: the publish period (and measurement period) should be checked upon construction.
There was a problem hiding this comment.
The unit tests are currently deliberately passing in invalid publish_periods to avoid this Collector::clearCurrentMeasurements() call.
There was a problem hiding this comment.
Then why not make zero valid and document as such? We only have an issue if the period is strictly less than zero.
| @@ -88,7 +83,7 @@ std::string PeriodicMeasurementNode::getStatusString() const | |||
| ", measurement_period=" << std::to_string(measurement_period_.count()) << "ms" << | |||
| ", publishing_topic=" << publishing_topic_ << | |||
| ", publish_period=" << | |||
| (publish_period_ != PeriodicMeasurementNode::DEFAULT_PUBLISH_WINDOW ? | |||
| (publish_period_ > std::chrono::milliseconds(0) ? | |||
There was a problem hiding this comment.
If done in construction then this is not needed.
dabonnie
reviewed
Dec 2, 2019
system_metrics_collector/src/system_metrics_collector/periodic_measurement_node.cpp
Show resolved
Hide resolved
dabonnie
approved these changes
Dec 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
DEFAULT_PUBLISH_WINDOWsentinel value as the publishing period should not be optional anymore.