This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
Add unit test for composeability of nodes #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piraka9011
reviewed
Jan 20, 2020
system_metrics_collector/test/system_metrics_collector/test_composition.cpp
Outdated
Show resolved
Hide resolved
zmichaels11
approved these changes
Jan 21, 2020
system_metrics_collector/test/system_metrics_collector/test_composition.cpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/test/system_metrics_collector/test_composition.cpp
Outdated
Show resolved
Hide resolved
dabonnie
suggested changes
Jan 21, 2020
system_metrics_collector/test/system_metrics_collector/test_composition.cpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/test/system_metrics_collector/test_composition.cpp
Outdated
Show resolved
Hide resolved
| for (const auto & class_name : class_names) { | ||
| ASSERT_TRUE(IsExpectedClassName(class_name)); | ||
| auto node_factory = loader->createInstance<rclcpp_components::NodeFactory>(class_name); | ||
| auto wrapper = node_factory->create_node_instance(options); |
There was a problem hiding this comment.
This can't be const because get_node_base_interface() is not a const member function.
dabonnie
approved these changes
Jan 21, 2020
|
Merged as build + test passed, but codecov is still broken. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for whether or not
libsystem_metrics_collector.socontains working composeable nodes. It is based on one of the composition demos.