Default values for line break mode and alignment #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemnovichkov
requested review from
Antowkos,
disabled,
evgenmikhaylov,
ntunin,
ReshetovE and
stason314
stason314
approved these changes
Nov 26, 2019
rosberry
approved these changes
Nov 27, 2019
ReshetovE
suggested changes
Nov 27, 2019
| //When | ||
| let copy = attributes.copy() | ||
| //Then | ||
| XCTAssertEqual(copy, attributes, "Copy is not equal to line attributes") |
There was a problem hiding this comment.
"Copy is not equal to line attributes"
NOT equal?
There was a problem hiding this comment.
I think so, this message contains a description what was wrong in this assertion
|
|
||
| //Then | ||
| XCTAssertEqual(style.font, .systemFont(ofSize: 12), "Default style font must be equal to system font of 12 size") | ||
| XCTAssertEqual(style.color, .black, "Default color must be equal to nil") |
There was a problem hiding this comment.
Suggested change
| XCTAssertEqual(style.color, .black, "Default color must be equal to nil") | |
| XCTAssertEqual(style.color, .black, "Default color must be equal to black") |
| //Then | ||
| XCTAssertEqual(style.font, .systemFont(ofSize: 12), "Default style font must be equal to system font of 12 size") | ||
| XCTAssertEqual(style.color, .black, "Default color must be equal to nil") | ||
| XCTAssertEqual(style.backgroundColor, .clear, "Default backgroundColor must be equal to nil") |
There was a problem hiding this comment.
Suggested change
| XCTAssertEqual(style.backgroundColor, .clear, "Default backgroundColor must be equal to nil") | |
| XCTAssertEqual(style.backgroundColor, .clear, "Default backgroundColor must be equal to clear") |
| XCTAssertEqual(style.font, .systemFont(ofSize: 12), "Default style font must be equal to system font of 12 size") | ||
| XCTAssertEqual(style.color, .black, "Default color must be equal to nil") | ||
| XCTAssertEqual(style.backgroundColor, .clear, "Default backgroundColor must be equal to nil") | ||
| XCTAssertEqual(style.ligature, nil, "Default ligature must be equal to nil") |
There was a problem hiding this comment.
Suggested change
| XCTAssertEqual(style.ligature, nil, "Default ligature must be equal to nil") | |
| XCTAssertNil(style.ligature, "Default ligature must be equal to nil") |
Comment on lines
107
to
118
| XCTAssertEqual(style.kerning, nil, "Default kerning must be equal to nil") | ||
| XCTAssertEqual(style.strokeWidth, nil, "Default strokeWidth must be equal to nil") | ||
| XCTAssertEqual(style.shadowStyle, nil, "Default shadowStyle must be equal to nil") | ||
| XCTAssertEqual(style.effectStyle, nil, "Default effectStyle must be equal to nil") | ||
| XCTAssertEqual(style.baselineOffset, nil, "Default baselineOffset must be equal to nil") | ||
| XCTAssertEqual(style.obliqueness, nil, "Default obliqueness must be equal to nil") | ||
| XCTAssertEqual(style.expansion, nil, "Default expansion must be equal to nil") | ||
| XCTAssertEqual(style.strikeThroughLine, nil, "Default strikeThroughLine must be equal to nil") | ||
| XCTAssertEqual(style.underlineLine, nil, "Default underlineLine must be equal to nil") | ||
| XCTAssertEqual(style.strokeColor, nil, "Default strokeColor must be equal to nil") | ||
| XCTAssertEqual(style.attachment, nil, "Default attachment must be equal to nil") | ||
| XCTAssertEqual(style.link, nil, "Default link must be equal to nil") |
There was a problem hiding this comment.
Here you can also replace XCTAssertEqual to XCTAssertNil
Comment on lines
121
to
125
| XCTAssertEqual(style.lineSpacing, nil, "Default lineSpacing must be equal to nil") | ||
| XCTAssertEqual(style.paragraphSpacing, nil, "Default paragraphSpacing must be equal to nil") | ||
| XCTAssertEqual(style.paragraphSpacingBefore, nil, "Default paragraphSpacingBefore must be equal to nil") | ||
| XCTAssertEqual(style.lineHeight, nil, "Default lineHeight must be equal to nil") | ||
| XCTAssertEqual(style.paragraphStyle, nil, "Default paragraphStyle must be equal to nil") |
ntunin
approved these changes
Nov 28, 2019
| //When | ||
| let copy = attributes.copy() | ||
| //Then | ||
| XCTAssertEqual(copy, attributes, "Copy is not equal to line attributes") |
There was a problem hiding this comment.
I think so, this message contains a description what was wrong in this assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
UILabeluses.naturaltext alignment and.byTruncatingTailline break mode. To leave default behaviour as is I added these default values to all styles. Related to #13